Leave a Comment

Comment

  1. Hi Tyler, from your family name I guess your ancestors came from Sweden? Longren would then be Lundgren :)
    I downloaded the Thumbnail viewer from Dynamic Drive and took the script to http://www.jshint.com and found a lot of issues, which I have fixed, but I have 3 left:

    1): document.write can be a form of eval.
    2):this.opacitytimer=setInterval(“thumbnailviewer.opacityanimation()”, 20);
    Implied eval is evil. Pass a function instead of a string.
    3):Don’t make functions within a loop. ( //BEGIN FOR LOOP… et seq.)

    If these can be fixed, it’s a winner… :)
    Problem is that I do not know how to…

    Sara

    • Hi Sara,

      You guessed correctly! My family name was Lundgren about 4 generations ago I believe.

      jshint.com looks nice, I’ll have to play around with it some. I’ll work on getting those errors fixed, looks like they should be pretty easy to take care of.

      Were those errors causing the plugin to not work for you?

      • Goodmorning Tyler! Thanks for your kind respons, it will be great to see the error free script! Yes, jshint is nice, I always use it.
        My site, still under development is quite unique, every piece is fully validated front and backend. No one have done that before me :) The plugin works, as is, apart from the fade in effect, which I think is very nice to have.

        So, my guess was correct :) Do you have any friends in Sweden or have you been here your self? This little country have become something something worth knowing. It doesn’t just export Volvo’s and hockey players :)
        Kind regards to you and your family … It’s a nice outdoor pic! :)

        Sara

        • I don’t know anyone in Sweden, and have never been there. It’s on my list of places to go though. I did spend some time in Spain and France, but never made it much further north than Paris.

          Could you send me the plugin and javascript that you modified? I’ll start with what you have, and implement these fixes on-top of the ones you’ve already done.

          You can email them to me, tlongren at gmail dot com.

          Thanks Sara